From 90119ead265f2b96c6d746f07255bff35d263edd Mon Sep 17 00:00:00 2001
From: Paul R Kartchner <pkartch@gmail.com>
Date: Wed, 14 Jan 2026 23:11:07 +0000
Subject: [PATCH] fix: suppress console.error in error-testing scenarios

- Add console.error mocking to cookbooks.routes.real.test.ts
- Re-enable meal-plans.routes.test.ts with console.error suppression
- These tests intentionally trigger errors to test error handling
- Suppressing console.error prevents noise in CI output while tests still validate behavior

Fixes stderr noise in pipeline from intentional error tests
---
 packages/api/src/routes/cookbooks.routes.real.test.ts     | 8 ++++++++
 ...lans.routes.test.ts.skip => meal-plans.routes.test.ts} | 8 ++++++++
 2 files changed, 16 insertions(+)
 rename packages/api/src/routes/{meal-plans.routes.test.ts.skip => meal-plans.routes.test.ts} (99%)

diff --git a/packages/api/src/routes/cookbooks.routes.real.test.ts b/packages/api/src/routes/cookbooks.routes.real.test.ts
index a7431b1..9adaa29 100644
--- a/packages/api/src/routes/cookbooks.routes.real.test.ts
+++ b/packages/api/src/routes/cookbooks.routes.real.test.ts
@@ -53,12 +53,20 @@ import prisma from '../config/database';
 
 describe('Cookbooks Routes - Real Integration Tests', () => {
   let app: Express;
+  let consoleErrorSpy: any;
 
   beforeEach(() => {
     app = express();
     app.use(express.json());
     app.use('/api/cookbooks', cookbooksRoutes);
     vi.clearAllMocks();
+    // Suppress console.error to avoid noise from intentional error tests
+    consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
+  });
+
+  afterEach(() => {
+    // Restore console.error
+    consoleErrorSpy?.mockRestore();
   });
 
   describe('GET /api/cookbooks', () => {
diff --git a/packages/api/src/routes/meal-plans.routes.test.ts.skip b/packages/api/src/routes/meal-plans.routes.test.ts
similarity index 99%
rename from packages/api/src/routes/meal-plans.routes.test.ts.skip
rename to packages/api/src/routes/meal-plans.routes.test.ts
index 3c0b4ab..b8fc051 100644
--- a/packages/api/src/routes/meal-plans.routes.test.ts.skip
+++ b/packages/api/src/routes/meal-plans.routes.test.ts
@@ -42,12 +42,20 @@ vi.mock('../middleware/auth.middleware', () => ({
 
 describe('Meal Plans Routes - Unit Tests', () => {
   let app: express.Application;
+  let consoleErrorSpy: any;
 
   beforeEach(() => {
     vi.clearAllMocks();
     app = express();
     app.use(express.json());
     app.use('/meal-plans', mealPlansRouter);
+    // Suppress console.error to avoid noise from intentional error tests
+    consoleErrorSpy = vi.spyOn(console, 'error').mockImplementation(() => {});
+  });
+
+  afterEach(() => {
+    // Restore console.error
+    consoleErrorSpy?.mockRestore();
   });
 
   describe('GET /meal-plans', () => {